Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

updated files to latest skeleton#198

Merged
rosesyrett merged 17 commits into
masterfrom
latest_skeleton
Feb 22, 2023
Merged

updated files to latest skeleton#198
rosesyrett merged 17 commits into
masterfrom
latest_skeleton

Conversation

@rosesyrett
Copy link
Copy Markdown
Contributor

@rosesyrett rosesyrett commented Feb 2, 2023

A PR to add in some recent pip skeleton things, like:

  • getting rid of setup.cfg and setup.py, replacing with pyproject.toml
  • updated documentation structure

I have not adopted the new dockerfile structure as it seemed to fail when I tried to use it. Also, I do distinguish between the dockerfile I use in production and for my vscode container, whereas it seems the new pip skeleton does not. The new devcontainer.json looks really good but I just cannot get it to work for some reason.

@rosesyrett rosesyrett requested a review from garryod February 2, 2023 17:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@f093cfc). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #198   +/-   ##
=========================================
  Coverage          ?   90.00%           
=========================================
  Files             ?       30           
  Lines             ?      990           
  Branches          ?        0           
=========================================
  Hits              ?      891           
  Misses            ?       99           
  Partials          ?        0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rosesyrett
Copy link
Copy Markdown
Contributor Author

rosesyrett commented Feb 2, 2023

One thing that confuses me at the moment is _version.py vs _version_git.py which has been in use historically. My repo uses the _version_git to figure out which version it should set as a default in the helm chart. I need to investigate if I can just replace _version_git with _version easily.

@garryod
Copy link
Copy Markdown
Contributor

garryod commented Feb 3, 2023

One thing that confuses me at the moment is _version.py vs _version_git.py which has been in use historically. My repo uses the _version_git to figure out which version it should set as a default in the helm chart. I need to investigate if I can just replace _version_git with _version easily.

_version_git.py has actually been replaced with setuptools_scm which generates _version.py as an artefact. It should be a drop in replacement provided you're not calling into any of the functions of _version_git (which would be odd)

@rosesyrett
Copy link
Copy Markdown
Contributor Author

rosesyrett commented Feb 21, 2023

I'm currently struggling to figure out why my container is not building...

@garryod
Copy link
Copy Markdown
Contributor

garryod commented Feb 21, 2023

I'm currently struggling to figure out why my container is not building...

During the CI, the job tries to run uvicorn src.diffcalc_api.server:app --host 0.0.0.0 --version (with the first 4 terms from the Dockerfile CMD and the last from the exec parameters. Ofcourse there is no --version option for uvicorn. I get around this by having my binary delegate to uvicorn in my __main__. See papermill_service for an example.

joeshannon
joeshannon approved these changes Feb 22, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@joeshannon joeshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some of the checks failed. Is that ok for now?

@rosesyrett
Copy link
Copy Markdown
Contributor Author

rosesyrett commented Feb 22, 2023

I'll have a look and see what's going on - shouldn't be failing!

@rosesyrett rosesyrett merged commit 6e80bb0 into master Feb 22, 2023
@rosesyrett rosesyrett deleted the latest_skeleton branch February 22, 2023 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@garryod garryod Awaiting requested review from garryod

1 more reviewer

@joeshannon joeshannon joeshannon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rosesyrett @garryod @joeshannon @callumforrester